Skip to content

Code Review

Based on this comparison

  • What was an example where mockk was actually necessary? If the mock type is the same as the actual type, extensions should still work
  • LdapManager Start variable names with lower case
  • GS - we should discuss this; even if ink_cov is more accurate, it doesn't make sense to introduce false positives and over detect colour than to have false negatives and underdetect colour. Plus we've established that ink_cov didn't seem to be public

General comments

  • Format code and optimize imports before submitting; otherwise in the future people may reformat and introduce way more diff lines than needed for review.
  • Use PR's so people can comment on the code; by now, we should honestly have reviews for all major changes